-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(products) : Add query builder to the Products Datasource #116
Draft
richie-ni
wants to merge
39
commits into
main
Choose a base branch
from
users/richie/grafana/products-datsource/add-query-builder
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(products) : Add query builder to the Products Datasource #116
richie-ni
wants to merge
39
commits into
main
from
users/richie/grafana/products-datsource/add-query-builder
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prove default value assignment
… and async assertions
…for user interactions
…ng; enhance query builder fields
…chie/grafana/products-datsource/add-query-builder
richie-ni
changed the base branch from
main
to
users/richie/grafana/products-datasource
January 20, 2025 04:48
richie-ni
changed the title
feat(Products) : Add query builder to the Products Datasource
feat(products) : Add query builder to the Products Datasource
Jan 20, 2025
…eryProducts test parameters
… into users/richie/grafana/products-datasource
…le replacement scenarios
…eyValueOperation file
…chie/grafana/products-datsource/add-query-builder
…chie/grafana/products-datsource/add-query-builder
…chie/grafana/products-datsource/add-query-builder
Base automatically changed from
users/richie/grafana/products-datasource
to
main
January 24, 2025 06:29
…rce with metricFindQuery
…sDataSource with metricFindQuery" This reverts commit 33ad95d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
As part of User Story 2792085: FE | Add Query Editor for Products Datasource, this PR contains the query builder integration and the required constants and templates required for the query builder
👩💻 Implementation
queryBuilderConstants.ts
in coreUpdatedAt
fieldProperties
field🧪 Testing
Added unit tests
🖥️ Screenshot
✅ Checklist