Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(routes/index): only render map client-side #93

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

nicholaschiang
Copy link
Owner

This patch fixes a server-client error that was occurring because react-simple-maps does not fully support server-side rendering.

I should fix this upstream, but this is a temporary fix to avoid surfacing the error message in my application.

Ref: zcreativelabs/react-simple-maps#337

@vercel
Copy link

vercel bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dolce ✅ Ready (Inspect) Visit Preview Aug 11, 2023 4:06am

Base automatically changed from nicholas/map to main August 10, 2023 00:44
@cypress
Copy link

cypress bot commented Aug 10, 2023

Passing run #496 ↗︎

0 2 0 0 Flakiness 0

Details:

fix(routes/index): only render map client-side
Project: dolce Commit: 9fcbb96466
Status: Passed Duration: 01:30 💡
Started: Aug 11, 2023 3:56 AM Ended: Aug 11, 2023 3:57 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

This patch fixes a server-client error that was occurring because
`react-simple-maps` does not fully support server-side rendering.

I should fix this upstream, but this is a temporary fix to avoid
surfacing the error message in my application.

Ref: zcreativelabs/react-simple-maps#337
@nicholaschiang nicholaschiang force-pushed the nicholas/ssr branch 2 times, most recently from 6d3a9b4 to 9fcbb96 Compare August 11, 2023 03:54
@nicholaschiang nicholaschiang merged commit 5689b73 into main Aug 11, 2023
@nicholaschiang nicholaschiang deleted the nicholas/ssr branch August 11, 2023 04:07
@nicholas-release-bot
Copy link

🎉 This PR is included in version 1.43.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant