Fix for Swift and more flexible tint #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids issues with importing FXBlurView.h into Swift bridging header
|
I though about adding a blend mode parameter myself, so I agree this should be merged asap. Adding a black tint color seemingly did nothing for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits here, the first prevents an issue with the Accelerate framework when importing FXBlurView into the Swift bridging header, the second provides more flexibility defining a tint colour. I'm not sure why you had a fixed tint alpha previously, but I needed to be able to alter the blend mode and alpha to get the effect I was looking for, so I removed the fixed alpha and added a blend mode property. Merge as you wish.
Cheers!