Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate remaining rules from DeclarationV1 API to DeclarationV2 #1954

Merged
merged 11 commits into from
Jan 3, 2025

Conversation

calda
Copy link
Collaborator

@calda calda commented Dec 27, 2024

This PR migrates the remaining rules using the DeclarationV1 API to instead use the improved DeclarationV2 API.

Now that all of the call sites are migrated, this PR also deletes the DeclarationV1 API and renames DeclarationV2 to simply Declaration.

Each commit is an individual step that can be reviewed independently. This PR doesn't make any functional changes, except where necessary to support the behavior differences between the old and new Declaration API. The biggest changes were to organizeDeclarations, which had to be restructured a bit.

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 99.12088% with 8 lines in your changes missing coverage. Please review.

Project coverage is 95.44%. Comparing base (01d7248) to head (08f8177).
Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
Sources/DeclarationType.swift 98.03% 5 Missing ⚠️
Sources/Rules/OrganizeDeclarations.swift 99.20% 2 Missing ⚠️
Sources/Formatter.swift 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1954      +/-   ##
===========================================
+ Coverage    95.19%   95.44%   +0.24%     
===========================================
  Files          138      138              
  Lines        25284    24939     -345     
===========================================
- Hits         24069    23802     -267     
+ Misses        1215     1137      -78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@calda calda force-pushed the cal--migrate-declaration-rules branch from f9eab37 to a3cbe0e Compare December 27, 2024 23:22
@calda calda force-pushed the cal--migrate-declaration-rules branch from a3cbe0e to 08f8177 Compare December 27, 2024 23:30
@calda calda merged commit 6db7324 into nicklockwood:develop Jan 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant