Migrate remaining rules from DeclarationV1 API to DeclarationV2 #1954
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the remaining rules using the
DeclarationV1
API to instead use the improvedDeclarationV2
API.Now that all of the call sites are migrated, this PR also deletes the
DeclarationV1
API and renamesDeclarationV2
to simplyDeclaration
.Each commit is an individual step that can be reviewed independently. This PR doesn't make any functional changes, except where necessary to support the behavior differences between the old and new
Declaration
API. The biggest changes were toorganizeDeclarations
, which had to be restructured a bit.