Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user directories section #142

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Add user directories section #142

merged 1 commit into from
Oct 22, 2024

Conversation

alexveecle
Copy link
Contributor

From #139.

data/crates.json Outdated Show resolved Hide resolved
@djc
Copy link
Collaborator

djc commented Oct 15, 2024

So why did you decide to show dirs over directories? It feels to me like the directories API is a bit more modular and higher-level which probably makes more sense for our intended audience.

@alexveecle
Copy link
Contributor Author

From #139 (reply in thread)

probably for dirs with directories mentioned in the notes (HTML links work in notes sections)

But I really don't have a strong opinion. Personally, being able to construct a nice path for my application with directories looks nice.

@nicoburns
Copy link
Owner

From #139 (reply in thread)

probably for dirs with directories mentioned in the notes (HTML links work in notes sections)

But I really don't have a strong opinion. Personally, being able to construct a nice path for my application with directories looks nice.

I also don't really have a strong opinion on this. I'd be tempted to list both as "recommendations" (noting that dirs is slightly lower-level and directories slightly higher level) and stick etcetera under "see also".

Tbh, it looks like dirs and directories crates really ought to be one crate. They're both tiny wrappers around dirs-sys.

@djc
Copy link
Collaborator

djc commented Oct 15, 2024

I also don't really have a strong opinion on this. I'd be tempted to list both as "recommendations" (noting that dirs is slightly lower-level and directories slightly higher level) and stick etcetera under "see also".

This sounds good to me.

Tbh, it looks like dirs and directories crates really ought to be one crate. They're both tiny wrappers around dirs-sys.

Agreed.

@alexveecle
Copy link
Contributor Author

Sorry, it's been a busy period. I tried to capture the latest suggestions here. Feel free to just overwrite with any wording you prefer- I'm also happy to apply any suggestions.

@nicoburns
Copy link
Owner

Thanks!

@nicoburns nicoburns enabled auto-merge (squash) October 22, 2024 12:03
@nicoburns nicoburns merged commit acda1d8 into nicoburns:main Oct 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants