dark mode #143
Open
dark mode #143
+317
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generates nicer default flexbox spacing
djc
reviewed
Nov 12, 2024
| @@ -1,5 +1,5 @@ | |||
| {% macro crate_table(purposes) %} | |||
| <table class="full-width fixed-layout"> | |||
| <table class="full-width fixed-layout"> | |||
There was a problem hiding this comment.
There are quite a few formatting/unrelated changes here, would be nice to isolate those in a separate commit to make it more obvious what is actually changed for the theming setup.
|
Thanks for working on this, will be great to have a dark mode setup here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick drive-by PR for a css based dark mode.
The base colors also got a bit adjusted into a basic theming system and some unused rules were removed. For now the default theme is set by the operating system.