Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 22: Fix 'unknown variant' failures #23

Merged
merged 1 commit into from
Aug 12, 2018

Conversation

nicokosi
Copy link
Owner

@nicokosi nicokosi commented Aug 3, 2018

Fix issue #22.

@nicokosi nicokosi added the wip Work In Progress label Aug 3, 2018
@nicokosi nicokosi force-pushed the issue_22_unknown_variant branch 5 times, most recently from 886d2fa to c2677c7 Compare August 12, 2018 14:17
@nicokosi nicokosi removed the wip Work In Progress label Aug 12, 2018
@nicokosi nicokosi force-pushed the issue_22_unknown_variant branch from c2677c7 to 488ce25 Compare August 12, 2018 14:34
Only keep used GitHub enums and set a default value for unused ones.

Use tip from documentation:
https://serde.rs/attr-default.html

This tip has been given by @dtolnay in this issue:
serde-rs/serde#1353
@nicokosi nicokosi force-pushed the issue_22_unknown_variant branch from 488ce25 to 9de3d26 Compare August 12, 2018 14:41
@nicokosi nicokosi merged commit 0abb031 into master Aug 12, 2018
@nicokosi nicokosi deleted the issue_22_unknown_variant branch August 12, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant