Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve map access #260

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Conversation

ddjnw1yu
Copy link
Collaborator

This PR is for the ticket - Improved access to all map types.

Copy link

cypress bot commented Jan 28, 2025

SPARC Vue3 Portal Testing    Run #427

Run Properties:  status check failed Failed #427  •  git commit ccf5447bae: Add space between FunctionalConnectivity
Project SPARC Vue3 Portal Testing
Branch Review improve-map-access
Run status status check failed Failed #427
Run duration 16m 58s
Commit git commit ccf5447bae: Add space between FunctionalConnectivity
Committer David J. Yu
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 23
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 179
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/cypress/e2e/mapsviewer.cy.js • 2 failed tests

View Output

Test Artifacts
Maps Viewer - ac > Provenance card for Rat Test Replay Screenshots
Maps Viewer - ac > Provenance card for Pig Test Replay Screenshots

@ddjnw1yu
Copy link
Collaborator Author

ddjnw1yu commented Jan 28, 2025

SPARC Vue3 Portal Testing    Run #415

Run Properties:  <img alt="status check failed" width="10" height="10" src="https://camo.githubusercontent.com/ce191f2ed15e540ea28844862a5b05965953f7fda5ae04d3aa5ec730899a106e/68747470733a2f2f6173736574732e637970726573732e696f2f6769746875622d70722d636f6d6d656e742d69636f6e732f6661696c65642e737667"> Failed [#415](https://cloud.cypress.io/projects/96rtme/runs/415/overview?utm_source=github&utm_medium=failed&utm_campaign=run%20number)  •  <img alt="git commit" width="10" height="10" src="https://camo.githubusercontent.com/0a4d777bd84d33143a9bd3359a9a5b9817b5b1201ffe6da7c3accaa1a0bc88de/68747470733a2f2f6173736574732e637970726573732e696f2f6769746875622d70722d636f6d6d656e742d69636f6e732f6769742d636f6d6d69742e737667"> [2e5a8dbe35](https://github.com/nih-sparc/sparc-app-2/commit/2e5a8dbe359d5ca823720909f10448aa326b487e): Update mapEntries structure
Test results
Tests that failed  Failures **2**
Tests that were flaky  Flaky **0**
Tests that did not run due to a developer annotating a test with .skip  Pending **23**
Tests that did not run due to a failure in a mocha hook  Skipped **0**
Tests that passed  Passing **179**
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/cypress/e2e/mapsviewer.cy.js • 2 failed tests
View Output

Test Artifacts
Maps Viewer - ac > Provenance card for Pig Test Replay Screenshots
Maps Viewer - ac > Provenance card for Rat Test Replay Screenshots

This is a known issue because the beta map viewer used here is not up-to-date. Currently, it is only used to test the feature. The version of @abi-software/mapintegratedvuer needs to be updated after the feature is tested and approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant