Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biolucida sharelink #261

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Biolucida sharelink #261

merged 4 commits into from
Jan 30, 2025

Conversation

alan-wu
Copy link
Contributor

@alan-wu alan-wu commented Jan 29, 2025

Use information from SciCrunch instead of Biolucida to create the sharelink. This will make the availability of images consistent with the image gallery. This feature can be tested here - https://alan-wu-sparc-app.herokuapp.com/

@alan-wu alan-wu requested review from ddjnw1yu and akhuoa January 29, 2025 05:29
Copy link

cypress bot commented Jan 29, 2025

SPARC Vue3 Portal Testing    Run #416

Run Properties:  status check passed Passed #416  •  git commit 81034ba194: Add a comment.
Project SPARC Vue3 Portal Testing
Branch Review biolucida-sharelink
Run status status check passed Passed #416
Run duration 17m 42s
Commit git commit 81034ba194: Add a comment.
Committer alan-wu
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 26
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 175
View all changes introduced in this branch ↗︎

Copy link
Collaborator

@akhuoa akhuoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Collaborator

@ddjnw1yu ddjnw1yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, image viewer loaded well.

@alan-wu alan-wu merged commit 26f8efc into nih-sparc:main Jan 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants