Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable presto #23958

Merged
merged 1 commit into from
Aug 15, 2024
Merged

disable presto #23958

merged 1 commit into from
Aug 15, 2024

Conversation

ringabout
Copy link
Member

No description provided.

@narimiran
Copy link
Member

I've seen it failing also on the version-2-0 branch (so, I'll backport this once merged), but I'm interested to know what's the reason for sudden fails. Looking at https://github.com/status-im/nim-presto, there were no new commits recently.
Any idea? Something external?

@ringabout
Copy link
Member Author

ringabout commented Aug 15, 2024 •
edited
Loading

I belive it is caused by some network issues(or something) on nim-presto tests

@narimiran
Copy link
Member

I belive it is caused by some network issues(or something) on nim-presto tests

Ok, I've created status-im/nim-presto#81 to see if the fails are reproducible there.

@narimiran
Copy link
Member

narimiran commented Aug 15, 2024 •
edited
Loading

2.0.x and devel failing there too. (But 1.6.x is not failing!!)

Looking at stuff in both those branches, merged/backported recently, #23892 looks suspicious, but that had green CIs before merging!?

@ringabout ringabout merged commit 06b25bd into devel Aug 15, 2024
8 checks passed
@ringabout ringabout deleted the ringabout-patch-9 branch August 15, 2024 10:00
@github-actions GitHub Actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 06b25bd

Hint: mm: orc; opt: speed; options: -d:release
173447 lines; 7.954s; 654.789MiB peakmem

@tersec
Copy link
Contributor

tersec commented Aug 17, 2024 •
edited
Loading

I've seen it failing also on the version-2-0 branch (so, I'll backport this once merged), but I'm interested to know what's the reason for sudden fails. Looking at https://github.com/status-im/nim-presto, there were no new commits recently. Any idea? Something external?

#23973 combined with arnetheduck/nim-results#46

narimiran pushed a commit that referenced this pull request Aug 19, 2024
@ringabout @narimiran
disable presto (#23958)
d6f7625 
(cherry picked from commit 06b25bd)
@ringabout ringabout restored the ringabout-patch-9 branch August 20, 2024 10:02
ringabout added a commit that referenced this pull request Aug 20, 2024
@ringabout
Revert "disable presto (#23958)"
73acde4 
This reverts commit 06b25bd.
@ringabout ringabout mentioned this pull request Aug 20, 2024
Merged
@ringabout ringabout deleted the ringabout-patch-9 branch August 20, 2024 10:03
ringabout added a commit that referenced this pull request Aug 20, 2024
@ringabout
Try to revert "disable presto" (#23987)
eed9cb0 
Reverts #23958

follow up #23981

ref #23958 (comment)
narimiran pushed a commit that referenced this pull request Aug 29, 2024
@ringabout @narimiran
Try to revert "disable presto" (#23987)
352c82a 
Reverts #23958

follow up #23981

ref #23958 (comment)

(cherry picked from commit eed9cb0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ringabout @narimiran @tersec