Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow local paths to be used for package specification. #1241

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Allow local paths to be used for package specification. #1241

wants to merge 5 commits into from

Commits on Jul 8, 2024

  1. Omit cloning if the package is on local 

    When developing local dependent packages, the unmodified implementation should use

```console
nimble develop file:///absolute/path/to/package
```

but this is not suitable for development since it will be cloned into a subdirectory.

If the package is a local package, it is easier to handle it as is without cloning.

With this change,

```console
nimble develop file:///absolute/path/to/package --withDependencies
```

would change nimble.develop as follows:

```diff
"dependencies": [
  ...
+ "absolute/path/to/package"
]
```
    @panno8M
    panno8M committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    0279167 View commit details
    Browse the repository at this point in the history

  2. Attempt to interpret as a file path before the package name 

    ```console
nimble develop file:///absolute/path/to/package
```

is still a bit cumbersome and confusing for those not familiar with uri.

```console
nimble develop /absolute/path/to/package
```

directory exists, the preferred UX would be to interpret this implicitly as file://.
    @panno8M
    panno8M committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    88fda43 View commit details
    Browse the repository at this point in the history

  3. Allow relative paths to be specified

    @panno8M
    panno8M committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    ea2ed50 View commit details
    Browse the repository at this point in the history

  4. Without the --withDependencies option, behaves the same as before

    @panno8M
    panno8M committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    940b24b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into pr-1241

    @ringabout
    ringabout authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    3883ff9 View commit details
    Browse the repository at this point in the history