Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delta >= 0
inenter
by making the argument typeNatural
(Go also supports negative deltas, but those would require special handling)leave
does nothing if no tasks have entered (it could also throw an exception, like Go does)runningTasks
is 0 (not a bug fix, but an optimization)broadcast
instead ofsignal
inleave
(this allows multiple threads towait
, there is a test for this)What do you think about the behaviour of
enter
ifdelta < 0
andleave
ifrunningTasks == 0
?