mirpasses: split assignments with MIR pass #1366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
observable behaviour
Details
splitAssignments
MIR pass and enable it for the C backendccgcalls.isHarmlessStore
, with the difference thatsplitAssignments
also considers projections of locals whenoptimizing away a split (not only unprojected locals)
ccgcalls
can now assume that all assignments are safe; everythingrelated to assignment splitting is removed
Observable stores
When the RHS of an assignment was an RVO-using call, the assignment was
not split, resulting in an "observable store" if the call raised an
exception after having modified its
result
variable.The
splitAssignments
call splits all assignments, incurring anadditional memory copy for RVO-using calls but also making the
behaviour "correct".
reportObservableStore
is obsolete and thusremoved.