PR#489 ("Fix typos") fixup

- Revert changes to BitcoinJS.js and OpenGSN.js. The changes are not immediately obvious in the minified code, and merging it would require thoroughly checking all changes, and updating the file hashes in the build script. Not worth the effort and/or risk. - Apply one typo fix made in HTML also to the English translation source strings. - Remove some outdated comments altogether. - Fix an additional typo.
nimiq · Feb 29, 2024 · 330159f · 330159f
1 parent 10037be
commit 330159f
Show file tree

Hide file tree

Showing 7 changed files with 6 additions and 16 deletions.
diff --git a/client/src/PublicRequest.ts b/client/src/PublicRequest.ts
@@ -303,7 +303,7 @@ export type SignSwapRequestCommon = SimpleRequest & {
             | 'sender' // Only known in second step (in swap-iframe)
             | 'senderType' // Must be HTLC
             | 'senderLabel' // Not used
-            | 'recipientType' // Must by BASIC (can only redeem to signer address)
+            | 'recipientType' // Must be BASIC (can only redeem to signer address)
             | 'flags' // Must be NONE, as it cannot be CONTRACT_CREATION
         >
         & { recipientLabel: string }

diff --git a/src/lib/bitcoin/BitcoinJS.js b/src/lib/bitcoin/BitcoinJS.js
diff --git a/src/lib/polygon/OpenGSN.js b/src/lib/polygon/OpenGSN.js
diff --git a/src/request/export/Export.js b/src/request/export/Export.js
@@ -9,10 +9,6 @@
 
 class Export {
     /**
-     * If a complete page is missing it will be created.
-     * However these pages will be the default pages which usually don't match the applications requirements.
-     * Refer to the corresponding _buildMoreExportOptions as well as
-     * the Build functions of ExportWords and ExportFile to see the general Structure.
      * @param {Parsed<KeyguardRequest.ExportRequest>} request
      * @param {Export.resolve} resolve
      * @param {reject} reject

diff --git a/src/request/export/ExportFile.js b/src/request/export/ExportFile.js
@@ -19,9 +19,6 @@
 
 class ExportFile extends Nimiq.Observable {
     /**
-     * if a complete page is missing it will be created.
-     * However these pages will be the default pages which usually don't match the applications requirements.
-     * Refer to the corresponding _build(Privacy | RecoveryWords | ValidateWords) to see the general Structure.
      * @param {Parsed<KeyguardRequest.ExportRequest>} request
      * @param {ExportFile.resolve} resolve
      * @param {reject} reject

diff --git a/src/request/export/ExportWords.js b/src/request/export/ExportWords.js
@@ -18,9 +18,6 @@
 
 class ExportWords extends Nimiq.Observable {
     /**
-     * if a complete page is missing it will be created.
-     * However these pages will be the default pages which usually don't match the applications requirements.
-     * Refer to the corresponding _build(Privacy | RecoveryWords | ValidateWords) to see the general Structure.
      * @param {Parsed<KeyguardRequest.ExportRequest>} request
      * @param {ExportWords.resolve} resolve
      * @param {reject} reject

diff --git a/src/translations/en.json b/src/translations/en.json
@@ -183,7 +183,7 @@
 
     "remove-key-heading": "Don't lose Access",
     "remove-key-intro-text": "If you log out without saving your account, you will irreversibly lose access to it!",
-    "remove-key-login-file-question": "Is your Login File savely stored and accessible?",
+    "remove-key-login-file-question": "Is your Login File safely stored and accessible?",
     "remove-key-download-login-file": "Download Login File",
     "remove-key-recovery-words-question": "Do you know where your Recovery Words are?",
     "remove-key-show-recovery-words": "Create a backup",