fix linter issues

.golangci.yaml

@@ -20,6 +20,7 @@ issues:
       linters:
         - gocognit
         - gocyclo
+        - gosec
 
   exclude-use-default: false # use default exclude patterns
   max-issues-per-linter: 0 # maximum issues count per one linter

examples_test.go

@@ -8,7 +8,7 @@ import (
 )
 
 func ExampleSample() {
-	rnd := newRndSeed(100)
+	rnd := newFixedRnd()
 
 	items := []int{1, 2, 3, 4, 5, 6, 7, 8, 9}
 	sample := sampler.Sample(rnd, items, 3)
@@ -18,7 +18,7 @@ func ExampleSample() {
 }
 
 func ExampleChoices() {
-	rnd := newRndSeed(100)
+	rnd := newFixedRnd()
 
 	items := []int{1, 2, 3, 4, 5, 6, 7, 8, 9}
 	choices := sampler.Choices(rnd, items, 3)
@@ -28,7 +28,7 @@ func ExampleChoices() {
 }
 
 func ExampleChoice() {
-	rnd := newRndSeed(100)
+	rnd := newFixedRnd()
 	items := []int{1, 2, 3, 4, 5, 6, 7, 8, 9}
 	choice := sampler.Choice(rnd, items)
 

sample_test.go

@@ -11,6 +11,8 @@ import (
 	"golang.org/x/exp/slices"
 )
 
+const seed = 100
+
 func BenchmarkAppend(b *testing.B) {
 	rnd := newRnd()
 	items := make([]int, 1000)
@@ -28,12 +30,10 @@ func BenchmarkAppend(b *testing.B) {
 }
 
 func TestSampleAppend(t *testing.T) {
-	const seed = 100
-
 	t.Run("n is 0", func(t *testing.T) {
 		t.Parallel()
 
-		rnd := newRndSeed(seed)
+		rnd := newFixedRnd()
 		dst := []int{1, 2, 3}
 		items := []int{4, 5, 6}
 
@@ -45,7 +45,7 @@ func TestSampleAppend(t *testing.T) {
 	t.Run("dst is nil, n is full shuffle", func(t *testing.T) {
 		t.Parallel()
 
-		rnd := newRndSeed(seed)
+		rnd := newFixedRnd()
 		var dst []int
 		items := []int{1, 2, 3}
 
@@ -58,7 +58,7 @@ func TestSampleAppend(t *testing.T) {
 	t.Run("dst is nil, n is partial shuffle", func(t *testing.T) {
 		t.Parallel()
 
-		rnd := newRndSeed(seed)
+		rnd := newFixedRnd()
 		var dst []int
 		items := []int{1, 2, 3}
 
@@ -71,7 +71,7 @@ func TestSampleAppend(t *testing.T) {
 	t.Run("dst is not nil, n is full shuffle", func(t *testing.T) {
 		t.Parallel()
 
-		rnd := newRndSeed(seed)
+		rnd := newFixedRnd()
 		dst := []int{4, 5, 6}
 		items := []int{1, 2, 3}
 
@@ -85,7 +85,7 @@ func TestSampleAppend(t *testing.T) {
 	t.Run("n is greater than or equal to len(items)", func(t *testing.T) {
 		t.Parallel()
 
-		rnd := newRndSeed(seed)
+		rnd := newFixedRnd()
 
 		dst := []int{1, 2, 3}
 		items := []int{4, 5, 6}
@@ -100,7 +100,7 @@ func TestSampleAppend(t *testing.T) {
 	t.Run("3*n is greater than len(items)", func(t *testing.T) {
 		t.Parallel()
 
-		rnd := newRndSeed(seed)
+		rnd := newFixedRnd()
 
 		dst := []int{1, 2, 3}
 		items := []int{4, 5, 6, 7, 8}
@@ -115,7 +115,7 @@ func TestSampleAppend(t *testing.T) {
 	t.Run("n is less than len(items)", func(t *testing.T) {
 		t.Parallel()
 
-		rnd := newRndSeed(seed)
+		rnd := newFixedRnd()
 		dst := []int{1, 2, 3}
 		items := []int{4, 5, 6, 7, 8, 9}
 
@@ -188,13 +188,14 @@ func assertPrefix[E comparable](t *testing.T, items, want []E) {
 
 func newRnd() *norand.Rand {
 	var seed [32]byte
-	rand.Read(seed[:])
+	_, _ = rand.Read(seed[:])
 
 	src := norand.NewChaCha8(seed)
 	return norand.New(src)
 }
 
-func newRndSeed(seed uint64) *norand.Rand {
+// returns a random generator with fixed seed
+func newFixedRnd() *norand.Rand {
 	var s [32]byte
 	binary.PutUvarint(s[:], seed)