Update the local state when preparing HTTP/3 headers

ninenines · Mar 20, 2024 · 3a5a90c · 3a5a90c
1 parent af3db83
commit 3a5a90c
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/cow_http3_machine.erl b/src/cow_http3_machine.erl
@@ -618,6 +618,12 @@ prepare_headers(StreamID, State=#http3_machine{encode_state=EncodeState0},
 		{_, <<"HEAD">>} -> fin;
 		_ -> IsFin0
 	end,
+	%% With QUIC we don't have a data queue so the local state
+	%% can be updated immediately.
+	LocalIsFin = case IsFin0 of
+		idle -> idle;
+		_ -> IsFin
+	end,
 	Headers = cow_http:merge_pseudo_headers(PseudoHeaders,
 		cow_http:remove_http1_headers(Headers0)),
 	{ok, HeaderBlock, EncData, EncodeState}
@@ -627,7 +633,7 @@ prepare_headers(StreamID, State=#http3_machine{encode_state=EncodeState0},
 			[] -> undefined;
 			_ -> {encoder_instructions, EncData}
 		end,
-		stream_store(Stream#bidi_stream{local=IsFin0},
+		stream_store(Stream#bidi_stream{local=LocalIsFin},
 			State#http3_machine{encode_state=EncodeState})}.
 
 -spec prepare_trailers(cow_http3:stream_id(), State, cow_http:headers())