Flush stdout before calling _setmode on windows #2453
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a partial regression of #773, where line endings in subprocess output are printed as CR CR LF on windows. The problem can be seen with the following build file:
Using
cat
from MinGW:Note the double
^M
s.I've bisected this to #2085, which enabled stdout buffering on windows. When
_setmode
is called, it seems that any buffered content also has the new mode applied to it (not the mode that was set when that content was written). Therefore, the buffer should be flushed before calling_setmode
. This is described under the "Remarks" section here:https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/setmode