-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Repair search for precomputed transforms #3369
Conversation
Thanks for opening this pull request! It looks like this is your first time contributing to fMRIPrep. 😄 |
daa7d49
to
69695ff
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3369 +/- ##
==========================================
+ Coverage 71.03% 71.59% +0.55%
==========================================
Files 56 57 +1
Lines 4233 4249 +16
Branches 638 639 +1
==========================================
+ Hits 3007 3042 +35
+ Misses 1114 1091 -23
- Partials 112 116 +4 ☔ View full report in Codecov by Sentry. |
f935685
to
bd290fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on the test:
Avoid possible bugs in `io_spec.json` during test Co-authored-by: Chris Markiewicz <[email protected]>
Simplify assertion in test for loaded transforms Co-authored-by: Chris Markiewicz <[email protected]>
…eparing to call collect_derivatives Co-authored-by: Chris Markiewicz <[email protected]>
Co-authored-by: Chris Markiewicz <[email protected]>
For remaining issues, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would you mind writing a similar test for the boldref
volumes? Can be in this PR or separate. I think we'll need to flip the direction of the q/entities
again.
👍🏻 #3370 |
Changes proposed in this pull request
Closes #3368
This required massaging several kinks from
collect_derivatives
, so careful review of that would be appreciated.Documentation that should be reviewed