-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: update fsl packages for reported bug fixes #3374
Conversation
FWIW, those failures look like scipy/scipy#21623 (comment) |
Can you look up the latest FSL release and see if the other pins we have are up to date? I'd rather move them as a group, as I expect they are tested together. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3374 +/- ##
=======================================
Coverage 71.70% 71.70%
=======================================
Files 57 57
Lines 4259 4259
Branches 640 640
=======================================
Hits 3054 3054
Misses 1090 1090
Partials 115 115 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retriggered the GHA jobs - this looks good to me
So if I understand correctly, this just means that these lines become unnecessary? Given that we aren't patching the TOPUP interface directly, this seems fairly safe. @mgxd Were you going to test on a dataset that has an odd number of slices? |
No, I don't believe so, the fix for the odd # of slices has to do with a configuration option ( From my understanding this fix will only be relevant/noticed on images with tight FOVs |
Changes proposed in this pull request
Closes #3373
Documentation that should be reviewed