FIX: Calculate bspline grids separately from colocation matrices #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
changed the title
Codecov ReportBase: 83.94% // Head: 90.70% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #308 +/- ##
==========================================
+ Coverage 83.94% 90.70% +6.76%
==========================================
Files 24 24
Lines 1999 1991 -8
Branches 232 305 +73
==========================================
+ Hits 1678 1806 +128
+ Misses 280 145 -135
+ Partials 41 40 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@oesteban This should be a fairly quick review. This fix is necessary for a release, regardless of whether we get in other improvements. |
effigies
commented
Dec 6, 2022
|
Replaces #300, correct? |
effigies
force-pushed
the
fix/grid_creation
branch
2 times, most recently
from
db9314f
to
7d5d007
Compare
effigies
force-pushed
the
fix/grid_creation
branch
from
7d5d007
to
6514401
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_collocation_matrixfunction introduced in #301 could produce slightly different knot spacings if the field of view changes sufficiently in resampling. The results of this function should be based entirely on the size of the input image, not a dynamic resampling.We therefore calculate the grid spacings before any resampling. This eliminates the need for a separate
_collocation_matrix, which can be done with a single call toscipy.sparse.vstack()over an iterable of sparse matrices.Closes #307.