FIX: Migrate from pkg_resources.resource_filename to importlib_resources
#378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
force-pushed
the
fix/pkg-resources-files
branch
2 times, most recently
from
0867938
to
9800c52
Compare
|
What do you think about nipreps/niworkflows#816? That would be pretty simple to duplicate over here and it handles the version differences correctly. |
|
Opened #379 as an alternative. |
Proposed in nipreps/niworkflows#816. Resolves: #377. Co-authored-by: Chris Markiewicz <[email protected]>
oesteban
force-pushed
the
fix/pkg-resources-files
branch
from
9800c52
to
2728da8
Compare
I saw this after pushing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #377.