fix: Only fit high-frequency spline for SyN-SDC #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #457 +/- ##
==========================================
- Coverage 76.40% 76.34% -0.06%
==========================================
Files 32 32
Lines 2814 2816 +2
Branches 376 377 +1
==========================================
Hits 2150 2150
- Misses 597 598 +1
- Partials 67 68 +1 ☔ View full report in Codecov by Sentry. |
effigies
force-pushed
the
fix/one-layer-syn
branch
from
1a351d9
to
18138d1
Compare
effigies
force-pushed
the
fix/one-layer-syn
branch
from
18138d1
to
6a9da18
Compare
|
@oesteban LMK what you think. |
oesteban
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #453, resolving similar issues for SyN-SDC as were resolved for GRE fieldmaps.