Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Dilate fmap and bold masks during coregistration #463

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

psadil
Copy link
Contributor

@psadil psadil commented Oct 2, 2024

Closes #461

The chosen radius (5 voxels) is a bit of a guess based on what has worked in the dataset where I was noticing failures. Input on a more systematic way to select this would be welcome.

@psadil
Copy link
Contributor Author

psadil commented Oct 2, 2024

Sorry, but it's not clear to me why that test is failing. I guess it's this doctest?

>>> find_estimators(
... layout=layouts['ds000054'],
... subject="100185",
... fmapless=False,
... ) # doctest: +ELLIPSIS
[FieldmapEstimation(sources=<3 files>, method=<EstimatorType.PHASEDIFF: 3>,
bids_id='auto_00000')]

@effigies
Copy link
Member

effigies commented Oct 2, 2024

Ah, it's global state and parallel tests interacting poorly. I'll figure out what's needed to isolate the state better.

@effigies effigies force-pushed the enh/dilate-mask-for-coregister branch from 183a74f to 85e0197 Compare October 3, 2024 14:42
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.68%. Comparing base (18e5e95) to head (85e0197).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
+ Coverage   83.66%   83.68%   +0.01%     
==========================================
  Files          32       32              
  Lines        2816     2819       +3     
  Branches      377      377              
==========================================
+ Hits         2356     2359       +3     
  Misses        390      390              
  Partials       70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit d953979 into nipreps:master Oct 3, 2024
13 checks passed
@psadil psadil deleted the enh/dilate-mask-for-coregister branch October 3, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dilate fmap and epi masks before coregistration
2 participants