Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

 [FIX] force_fmapless on top of self-correcting pepolar bold #465

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bpinsard
Copy link
Contributor

@bpinsard bpinsard commented Oct 9, 2024

When force_fmapless is used on top of self-correcting pepolar bold, the fmapless estimator will get it's name from B0FieldIdentifier, creating a duplicate.
For now I just created a test to replicate that behavior and triggering the error that this PR will try to fix.

@bpinsard
Copy link
Contributor Author

bpinsard commented Oct 9, 2024

Also, it seems there was no test for force_fmapless=True.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.70%. Comparing base (656a51d) to head (dc6d2f7).

❗ There is a different number of reports uploaded between BASE (656a51d) and HEAD (dc6d2f7). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (656a51d) HEAD (dc6d2f7)
12 4
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
- Coverage   83.75%   74.70%   -9.05%     
==========================================
  Files          32       32              
  Lines        2831     2831              
  Branches      381      284      -97     
==========================================
- Hits         2371     2115     -256     
- Misses        390      653     +263     
+ Partials       70       63       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant