Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL: 2.5.0 #779

Merged
merged 5 commits into from
Aug 4, 2019
Merged

REL: 2.5.0 #779

merged 5 commits into from
Aug 4, 2019

Conversation

effigies
Copy link
Member

@effigies effigies commented Jul 29, 2019

About time for our trimesterly minor release.

Open issues/PRs that could go in quickly

Closes #781.

Pre-release checklist

  • Review the open list of nibabel issues. Check whether there are outstanding issues that can be closed, and whether there are any issues that should delay the release. Label them!
  • Review and update the release notes. Review and update the Changelog file.
  • Look at doc/source/index.rst and add any authors not yet acknowledged.
  • Use the opportunity to update the .mailmap file if there are any duplicate authors listed from git shortlog -nse.
  • Check the copyright year in doc/source/conf.py
  • Refresh the README.rst text from the LONG_DESCRIPTION in info.py by running make refresh-readme.
  • Check the dependencies listed in nibabel/info.py (e.g. NUMPY_MIN_VERSION) and in doc/source/installation.rst and in requirements.txt and .travis.yml. They should at least match. Do they still hold? Make sure nibabel on travis is testing the minimum dependencies specifically.
  • Make sure all tests pass (from the nibabel root directory): nosetests --with-doctest nibabel
  • Edit nibabel/info.py to set _version_extra to ''; commit

Adapted from http://nipy.org/nibabel/devel/make_release.html#release-checklist

@effigies effigies added this to the 2.5.0 milestone Jul 29, 2019
@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@7ee4aa6). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #779   +/-   ##
=========================================
  Coverage          ?   89.99%           
=========================================
  Files             ?       94           
  Lines             ?    12009           
  Branches          ?     2133           
=========================================
  Hits              ?    10807           
  Misses            ?      858           
  Partials          ?      344
Impacted Files Coverage Δ
nibabel/info.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ee4aa6...580f75c. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #779 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #779   +/-   ##
=======================================
  Coverage   90.03%   90.03%           
=======================================
  Files          94       94           
  Lines       12018    12018           
  Branches     2136     2136           
=======================================
  Hits        10821    10821           
  Misses        852      852           
  Partials      345      345
Impacted Files Coverage Δ
nibabel/info.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ee4aa6...3994fa5. Read the comment docs.

@effigies
Copy link
Member Author

effigies commented Aug 2, 2019

I'm pushing off #712 for now, and we're ready for release.

@yarikoptic Care to run your tests for Debian?
@sanjayankur31 And Fedora?

@sanjayankur31
Copy link

@sanjayankur31 And Fedora?

Looks good. Here is a successful test build on s390x:
https://koji.fedoraproject.org/koji/taskinfo?taskID=36761683

All tests pass properly. Thanks very much! 🍾

@yarikoptic
Copy link
Member

running across neurodebians ATM
for me also succeeded on s390 debian sid

@effigies
Copy link
Member Author

effigies commented Aug 4, 2019

Great! Thanks for the confirmation.

@effigies effigies merged commit 7fa0a9e into master Aug 4, 2019
@effigies effigies deleted the rel/2.5.0 branch August 4, 2019 13:05
@effigies effigies mentioned this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure with numpy 1.17.0
3 participants