Allow //exhaustive:ignore on potential enums
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes nishanths#76 This PR enables the syntax: ```go type DeclIgnoredEnum int // want no enum detected //exhaustive:ignore const ( DeclIgnoredMamberA DeclIgnoredEnum = 1 DeclIgnoredMamberB DeclIgnoredEnum = 2 ) //exhaustive:ignore const DeclIgnoredMamberC DeclIgnoredEnum = 3 ```
nishanths
reviewed
Apr 18, 2024
|
Thanks for the pull request. I added some comments. |
iwahbe
force-pushed
the
iwahbe/76/allow-ignore-on-potential-enums
branch
2 times, most recently
from
879bd2c to
fc6d38d
Compare
Adds support for the syntax: ```go //exhaustive:ignore type DeclTypeIgnoredEnum int const ( DeclTypeIgnoredMamberA DeclTypeIgnoredEnum = 1 DeclTypeIgnoredMamberB DeclTypeIgnoredEnum = 2 ) ```
iwahbe
force-pushed
the
iwahbe/76/allow-ignore-on-potential-enums
branch
from
fc6d38d to
ce37a1d
Compare
|
Hey @nishanths. Thanks for the excellent feedback. I have addressed your comments. |
nishanths
reviewed
Apr 27, 2024
|
Added a few more comments (one blocking). Looks good to me after that. |
|
Thanks for the feedback. I addressed it and am ready for another round of review. I really appreciate your patience here. |
You're welcome, and it's no problem at all. Thank you for updating! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
This PR enables these examples:
Ignoring declared constants (d9dc665):
Ignoring declared types (272c2ab):
Both commits are under test.