Skip to content

Commit

Permalink
rename frontend to react-client in files
Browse files Browse the repository at this point in the history
  • Loading branch information
nishkohli96 committed Apr 11, 2024
1 parent 501e656 commit 191b833
Show file tree
Hide file tree
Showing 4 changed files with 37 additions and 36 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/docker-img.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
# - name: Build Server Image
# run: docker build -f ./apps/fastify-server/Dockerfile -t ${{secrets.DOCKER_HUB_USERNAME}}/rnm-server:${{ steps.date.outputs.date }} .

# - name: Build Frontend Image
# run: docker build -f ./apps/frontend/Dockerfile -t ${{ secrets.DOCKER_HUB_USERNAME }}/rnm-frontend:${{ steps.date.outputs.date }} .
# - name: Build react-client Image
# run: docker build -f ./apps/react-client/Dockerfile -t ${{ secrets.DOCKER_HUB_USERNAME }}/rnm-react-client:${{ steps.date.outputs.date }} .

# - name: Login to DockerHub
# uses: docker/login-action@v2
Expand All @@ -37,5 +37,5 @@
# - name: Push Backend Image to Docker Hub
# run: docker push ${{ secrets.DOCKER_HUB_USERNAME }}/rnm-server:${{ steps.date.outputs.date }}

# - name: Push Frontend Image to Docker Hub
# run: docker push ${{ secrets.DOCKER_HUB_USERNAME }}/rnm-frontend:${{ steps.date.outputs.date }}
# - name: Push react-client Image to Docker Hub
# run: docker push ${{ secrets.DOCKER_HUB_USERNAME }}/rnm-react-client:${{ steps.date.outputs.date }}
4 changes: 2 additions & 2 deletions .github/workflows/github-actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ jobs:
- name: Build nestjs-server
run: yarn workspace nestjs-server build

- name: Build frontend
run: yarn workspace frontend build
- name: Build react-client
run: yarn workspace react-client build

- name: Build next-client
run: yarn workspace next-client build
10 changes: 5 additions & 5 deletions Docker-commands.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
# Docker Commands

1. Build `frontend` image
1. Build `react-client` image

```
docker build -f ./apps/frontend/Dockerfile -t docker_username/frontend.
docker build -f ./apps/react-client/Dockerfile -t docker_username/react-client.
```

2. Run Image

```
docker run -p 3000:3000 docker_username/frontend
docker run -p 3000:3000 docker_username/react-client
```

3. Run Image with [Volume Mount](https://docs.docker.com/get-started/06_bind_mounts/)

```
docker run -p 3000:3000 -v /app/node_modules -v "$(pwd):/app" docker_username/frontend
docker run -p 3000:3000 -v /app/node_modules -v "$(pwd):/app" docker_username/react-client
```

If using the `-v /app/node_modules` flag, you don't need to install `node_modules` folder. It means that not to take reference for `node_modules` in the actual directory
Expand All @@ -29,7 +29,7 @@ docker-compose up
To run a particular service,

```
docker-compose up [serviceName] // eg. frontend-dev
docker-compose up [serviceName] // eg. react-client-dev
```

Add `--build` flag to rebuild and then restart containers.
Expand Down
51 changes: 26 additions & 25 deletions compose.yml
Original file line number Diff line number Diff line change
@@ -1,24 +1,41 @@
services:
# run frontend-prod build on Port 5000
frontend:
image: docker_username/frontend
express-server:
image: docker_username/express-server
build:
context: .
dockerfile: ./apps/express-server/Dockerfile
ports:
- '5000:5000'

# somehow port mapping not working for this
nestjs-server:
image: docker_username/nestjs-server
build:
context: .
dockerfile: ./apps/nestjs-server/Dockerfile
ports:
- '4000:4000'

# run react-client-prod build on Port 5000
react-client:
image: docker_username/react-client
build:
context: .
dockerfile: ./apps/frontend/Dockerfile
dockerfile: ./apps/react-client/Dockerfile
ports:
- '3000:80'

# run frontend in dev mode on Port 3000, with hot reloading
frontend-dev:
image: docker_username/frontend-dev
# run react-client in dev mode on Port 3000, with hot reloading
react-client-dev:
image: docker_username/react-client-dev
build:
context: .
dockerfile: ./apps/frontend/Dockerfile.dev
dockerfile: ./apps/react-client/Dockerfile.dev
ports:
- '3001:3000'
volumes:
- '/app/node_modules'
- './apps/frontend:/app/apps/frontend'
- './apps/react-client:/app/apps/react-client'

next-client:
image: docker_username/next-client
Expand All @@ -28,19 +45,3 @@ services:
ports:
- '3002:3000'

express-server:
image: docker_username/express-server
build:
context: .
dockerfile: ./apps/express-server/Dockerfile
ports:
- '5000:5000'

# somehow port mapping not working for this
nestjs-server:
image: docker_username/nestjs-server
build:
context: .
dockerfile: ./apps/nestjs-server/Dockerfile
ports:
- '4000:4000'

0 comments on commit 191b833

Please sign in to comment.