Skip to content

Commit

Permalink
eslint wip
Browse files Browse the repository at this point in the history
  • Loading branch information
nishkohli96 committed Feb 1, 2024
1 parent bbe2308 commit a65022f
Show file tree
Hide file tree
Showing 5 changed files with 2,363 additions and 657 deletions.
22 changes: 22 additions & 0 deletions apps/frontend/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"extends": ["@nish1896"]
// "env": {
// "node": true,
// "browser": true,
// /** use "test or expect" without any lint err */
// "jest": true
// },
// "extends": [
// "eslint:recommended",
// "plugin:@typescript-eslint/recommended",
// "plugin:react/recommended",
// "plugin:react-hooks/recommended",
// "plugin:jsx-a11y/recommended"
// ],
// "parser": "@typescript-eslint/parser",
// "plugins": ["@typescript-eslint"],
// "rules": {
// "no-mixed-spaces-and-tabs": "off"
// }
}

1 change: 1 addition & 0 deletions apps/frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"dev": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test",
"lint": "eslint --fix .",
"eject": "react-scripts eject"
},
"dependencies": {
Expand Down
4 changes: 2 additions & 2 deletions apps/frontend/src/pages/Home.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const HomePage = () => {

return (
<div className="root">
<div style={{ margin: '10px 0px' }}>Hello from the HomePage.</div>
<div style={{ margin: '10px 0px' }}>Hello from the HomePage.</div>
<div style={{ margin: '10px 0px' }}>
<p>
This component exported from <b>@core/lib</b>
Expand All @@ -20,7 +20,7 @@ const HomePage = () => {
<Loading />
) : (
<Fragment>
{Boolean(pokemonList?.length)
{pokemonList?.length
? pokemonList?.map((pokemon, idx) => (
<Typography color='primary' key={idx}>{pokemon.name}</Typography>
))
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"prettier": "prettier --write *"
},
"devDependencies": {
"@nish1896/eslint-config": "^1.0.3",
"eslint": "^8.56.0",
"husky": "^9.0.7",
"lint-staged": "^15.2.1",
Expand Down
Loading

0 comments on commit a65022f

Please sign in to comment.