Podspec fix for people using CocoaPods for distribution and not NPM #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@orta what will happen if I pull in the native mapbox ios sdk thru my podfile? |
|
Hrm, good Q, let's see how that works - might be able to close this |
|
Looking good, I get framework conflicts. Perhaps this PR can be switched to documentation on the README. |
|
@orta thanks for checking it out, I with updating the documentation on this PR and we can get it merged in. |
|
Happy to see where this goes instead: #1533 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically during the install process
npmcallsnode ./scripts/download-mapbox-gl-native-ios-if-on-mac.js 3.7.8to download the MapBox SDK: hereHowever, when you install this library via CocoaPods (when separating your JS / native code ) then this script doesn't run. This allows CocoaPods consumers to also get a copy of the framework.