Make the executable read .env files properly. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… same directory that the binary is.
fde-capu
force-pushed
the
env_from_binpath
branch
from
86397ba to
4c12ba2
Compare
fde-capu
force-pushed
the
env_from_binpath
branch
from
4b4ed8c to
381de77
Compare
|
Following troubleshooting and numerous attempts to resolve the issue, I have successfully imported godotenv, yet the test continues to fail. The failure is attributed to the use of golangci-lint in the build test, which is incompatible with Go 1.19 (despite merging the 'downgrade' PR into this). A potential solution could involve either removing the linting test phase or further downgrading to Go 1.18, which has not been tested by me, and seems awkward. This PR was intended to simplify the process of configuring the API key. However, it is standard practice to allow end users to manage this configuration. Given the circumstances, it seems the most prudent course of action is to leave the current setup unchanged. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I identified an issue where navi failed to locate the .env file when running from outside its binary directory. This caused problems for users who prefer not to store the environment variable GEMINI_API_KEY in their .bashrc.
To address this, the program now searches for the .env file within the same directory as the binary itself. This fix should ensure successful retrieval regardless of the execution location.