Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid superfluous response.WriteHeader call #811

Merged
merged 2 commits into from
Oct 30, 2024
Merged

fix: avoid superfluous response.WriteHeader call #811

merged 2 commits into from
Oct 30, 2024

Conversation

jyecusch
Copy link
Member

@jyecusch jyecusch commented Oct 30, 2024 •
edited
Loading

Fixes this:
error image

tjholm
tjholm previously approved these changes Oct 30, 2024
View reviewed changes
@jyecusch jyecusch dismissed stale reviews from HomelessDinosaur and tjholm via 0796f38 October 30, 2024 03:16
@jyecusch jyecusch merged commit f08eeeb into nitrictech:main Oct 30, 2024
4 checks passed
@nitric-bot
Copy link
Contributor

🎉 This PR is included in version 1.54.18 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davemooreuws davemooreuws davemooreuws approved these changes

@tjholm tjholm tjholm approved these changes

@HomelessDinosaur HomelessDinosaur HomelessDinosaur left review comments

Assignees

@davemooreuws davemooreuws

@tjholm tjholm

@HomelessDinosaur HomelessDinosaur

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jyecusch @nitric-bot @davemooreuws @tjholm @HomelessDinosaur