Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add podman support #815

Merged
merged 7 commits into from
Nov 5, 2024
Merged

fix: add podman support #815

merged 7 commits into from
Nov 5, 2024

Conversation

jyecusch
Copy link
Member

@jyecusch jyecusch commented Nov 1, 2024

Fallback to Podman if Docker is unavailable.

@jyecusch
Copy link
Member Author

jyecusch commented Nov 1, 2024

This still relies on nitrictech/examples#82 to also make TS projects compatible with Podman, since they use a cache setting that's not supported by Podman sharing=private.

The choosen provider used in stack files also needs to support podman.

pkg/view/tui/dependency.go Outdated Show resolved Hide resolved
tjholm
tjholm previously approved these changes Nov 4, 2024
tjholm
tjholm previously approved these changes Nov 5, 2024
Copy link
Member

@davemooreuws davemooreuws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this error when trying nitric up with no docker running:

 error  exit status 1

used to be

error  docker is required to run this command. For installation instructions see: https://docs.docker.com/engine/install/

@jyecusch jyecusch merged commit f1873fb into nitrictech:main Nov 5, 2024
4 checks passed
@nitric-bot
Copy link
Contributor

🎉 This PR is included in version 1.55.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants