move json parsing into format to avoid error on invalid json response #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HomelessDinosaur
requested review from
jyecusch,
davemooreuws,
tjholm and
raksiv
davemooreuws
approved these changes
Jan 7, 2025
tjholm
approved these changes
Jan 8, 2025
|
🎉 This PR is included in version 1.56.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a response in the dashboard had invalid json, the response content component would have a spinner running indefinitely. This fix moves the json parsing from the response body and into the
formatJsonmethod. If it is invalid or bytes, it will produce the result in the content box directly rather than an unexpected error.