Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't overwrite blobRequest event fields #225

Merged
merged 2 commits into from
Apr 11, 2024
Merged

fix: Don't overwrite blobRequest event fields #225

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34fba02
fix: Don't overwrite blobRequest event fields.
tjholm Apr 11, 2024
d421234
lint.
tjholm Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/api/storage/v1/storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export class Bucket {
notificationPrefixFilter,
...middleware
);
return notification['start']();
return notification['start'](this);
}
}

Expand Down
6 changes: 0 additions & 6 deletions src/resources/bucket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,6 @@ export class BucketNotification {
responseMessage.setId(message.getId());

try {
blobEventRequest.setBucketName(this.options.bucket);
const blobEvent = new BlobEvent();
blobEvent.setKey(this.options.notificationPrefixFilter);
blobEvent.setType(this.options.notificationType);
blobEventRequest.setBlobEvent(blobEvent);

if (bucket) {
const ctx = BlobEventContext.fromRequest(
blobEventRequest,
Expand Down
Loading