Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency globby to v14 #1900

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 9, 2023

Mend Renovate logo banner

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
globby ^13.2.2 -> ^14.0.0 age adoption passing confidence

Release Notes

sindresorhus/globby (globby)

v14.0.0

Compare Source

Breaking
Improvements

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/globby-14.x branch 4 times, most recently from eb01598 to 37d109e Compare November 12, 2023 19:49
@pi0
Copy link
Member

pi0 commented Nov 12, 2023

Here we go this is first engine-incompatible/runtime-compatible dependency..

npm seems to use soft warnings:

image

pnpm (interestingly) not even a warning

image

yarn fails:

image

Considering pnpm and npm the major package managers have soft warning behavior and issue with yarn is solvable using skip-engines flag ++ Node.js 16 is EOL for a while and to avoid stalling behind more dependencies, i am thinking to do this by next minor release with clear instruction for users that really have no option rather than sticking with Node 16. More and more (nested) dependencies such as @sindresorhus/merge-streams are being Node 18 and this change is inevitable.

/cc @danielroe If you have serious concerns about delaying this, love to hear and discuss alternatives.

@renovate renovate bot force-pushed the renovate/globby-14.x branch 3 times, most recently from 34ab46b to c295e17 Compare November 13, 2023 13:05
@pi0
Copy link
Member

pi0 commented Nov 14, 2023

Seems Nuxt (via devtools, tailwindcss) already has Node 18 depednency is-installed-globally (it is also soft-warn)

image image

@renovate renovate bot force-pushed the renovate/globby-14.x branch from c295e17 to 62626db Compare November 14, 2023 02:50
@renovate renovate bot force-pushed the renovate/globby-14.x branch from 62626db to eaf4331 Compare November 14, 2023 03:04
@danielroe
Copy link
Member

Thank you for the research. I'm happy to go ahead. We should add something to Nuxt docs too (as well, perhaps, as Nitro's).

@pi0 pi0 merged commit afd1454 into main Nov 14, 2023
5 checks passed
@pi0 pi0 deleted the renovate/globby-14.x branch November 14, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants