Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aws amplify hosting preset #1912

Merged
merged 7 commits into from
Nov 16, 2023
Merged

feat: add aws amplify hosting preset #1912

merged 7 commits into from
Nov 16, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Nov 14, 2023

πŸ”— Linked issue

Resolves #80

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Note: AWS Amplify support is still in progress with amplify team collaboration πŸš€ (special thanks to @Narrator)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation as needed.

Copy link
Contributor

nuxt-studio bot commented Nov 14, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview 144800a

@pi0 pi0 changed the title feat: add aws amplify preset feat: add aws amplify hosting preset Nov 14, 2023
Copy link

@Narrator Narrator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks great.

Left a couple of comments:

  • The types for AmplifyImageSettings need to be fixed.
  • Suggestion to rename the computeStaticFallback field

src/types/presets/aws-amplify.ts Outdated Show resolved Hide resolved
src/types/presets/aws-amplify.ts Show resolved Hide resolved
src/types/presets/aws-amplify.ts Outdated Show resolved Hide resolved
@pi0 pi0 merged commit 0437fd0 into main Nov 16, 2023
@pi0 pi0 deleted the feat/aws-amplify branch November 16, 2023 11:22
@pi0 pi0 mentioned this pull request Nov 19, 2023
@fotografAI
Copy link

can anyone enlight me where to put env. variables!?? It's a common question:
I have .env variables:
SUPABASE_URL=""
SUPABASE_KEY=""
STRIPE_SECRET_KEY=""
STRIPE_PUBLIC_KEY=""
ENDPOINT_SECRET=""

Now, how to add the variables???
I've tried to ass them from Environment variables in aws amplify console, For the 1st variable i;ve tried: PUBLIC_SUPABASE_URL, SUPABASE_URL, supabaseUrl. Nothing works.

:( I'm baffled. Any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws amplify
3 participants