-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking βSign up for GitHubβ, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable allowImportingTsExtensions
by default
#3029
Conversation
src/core/build/types.ts
Outdated
@@ -217,6 +217,8 @@ declare module "nitro/types" { | |||
jsx: "preserve", | |||
jsxFactory: "h", | |||
jsxFragmentFactory: "Fragment", | |||
allowImportingTsExtensions: true, | |||
rewriteRelativeImportExtensions: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not required for us as nitro does not use tsc compiler.
allow importing ts extensions is nice (we could also backport it to v2 branch as non breaking change)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which structure do we broadcast from without tsc ? Which place in the code should I examine. I need to learn this structure
my computer pnpm install this problem. How to fixed ? Details
.../node_modules/better-sqlite3 install$ prebuilβ¦ dev-nitro on ξ v2 is π¦ v2.10.4 via ξ v22.12.0 took 45s |
allowImportingTsExtensions
by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
You need to use Node.js v20, sadly an issue with |
π Linked issue
β Type of change
π Description
Type stripping works with most versions of TypeScript but we recommend version 5.7 or newer with the following tsconfig.json settings: nodejs docs
π Checklist