fix(netlify): avoid second bundling #3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
commented
Jan 29, 2025
| @@ -116,6 +116,8 @@ export const config = { | |||
| name: "server handler", | |||
| generator: "${getGeneratorString(nitro)}", | |||
| path: "/*", | |||
| nodeBundler: "none", | |||
| includedFiles: ["**"], | |||
There was a problem hiding this comment.
@serhalp this pattern is scoped to function dir right?
pi0
commented
Jan 29, 2025
| @@ -116,6 +116,8 @@ export const config = { | |||
| name: "server handler", | |||
|
Merging to try on nightly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Found while investigating nuxt/nuxt#30789 (comment)
Netlify functions (both user and framework internals) are bundled by default via a last esbuild step. (netlify docs) this is an unnecessary step for Nitro as nitro already makes an optimized bundle output.
In the legacy netify v1 preset, we were using
nodeModuleFormat: "esm"to preserve ESM compatibility however it is broken currently with v2 format (#2406) in 2.10.0With this PR, ESM compat of output remains as-is