Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cloudflare): improve wrangler merge #3065

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Feb 5, 2025

Followup on #2949 and #3064 /cc @@petebacondarwin

This PR improves merging logic for generating wrangler.json:

  • pages_build_output_dir, main and assets are always overridden + nitro shows warn when it does (this is because, relative paths in generated config are different than user ones
  • nodejs_compat related flags are added with more care:
    • If user sets both nodejs_compat_v2 and no_nodejs_compat_v2, we warn + remove nodejs_compat_v2
    • If user sets only nodejs_compat_v2, we warn about incompatibility and avoid adding any defaults
    • otherwise we add nodejs_compat + no_nodejs_compat_v2

@pi0 pi0 merged commit ccfda71 into v2 Feb 5, 2025
4 checks passed
@pi0 pi0 deleted the refactor/cf-config-handling branch February 5, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant