refactor(cloudflare): improve wrangler merge #3065
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on #2949 and #3064 /cc @@petebacondarwin
This PR improves merging logic for generating
wrangler.json
:pages_build_output_dir
,main
andassets
are always overridden + nitro shows warn when it does (this is because, relative paths in generated config are different than user onesnodejs_compat_v2
andno_nodejs_compat_v2
, we warn + removenodejs_compat_v2
nodejs_compat_v2
, we warn about incompatibility and avoid adding any defaultsnodejs_compat
+no_nodejs_compat_v2