Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ymstnt repository #826

Merged
merged 1 commit into from
Feb 10, 2025
Merged

add ymstnt repository #826

merged 1 commit into from
Feb 10, 2025

Conversation

ymstnt
Copy link
Contributor

@ymstnt ymstnt commented Feb 10, 2025

The following points apply when adding a new repository to repos.json

  • I ran ./bin/nur format-manifest after updating repos.json (We will use the same script in github actions to make sure we keep the format consistent)
  • By including this repository in NUR, I confirm that any copyrightable content in the repository (other than built derivations or patches, if applicable) is licensed under the MIT license
  • I confirm that meta.license and meta.sourceProvenance have been set correctly for any derivations for unfree or not built from source packages

Additionally, the following points are recommended:

  • All applicable meta fields have been filled out. See https://nixos.org/manual/nixpkgs/stable/#sec-standard-meta-attributes for more information. The following fields are particularly helpful and can always be filled out:
    • meta.description, so consumers can confirm that that your package is what they're looking for
    • meta.license, even for free packages
    • meta.homepage, for tracking and deduplication
    • meta.mainProgram, so that nix run works correctly

@Pandapip1
Copy link
Collaborator

beepers meta.sourceProvenance is not correctly set

@ymstnt
Copy link
Contributor Author

ymstnt commented Feb 10, 2025

beepers meta.sourceProvenance is not correctly set

Thanks, fixed it.
I've set it to lib.sourceTypes.binaryNativeCode because it's a wrapped AppImage built by a third-party.

The change has been pushed, please, take a look at it again.

Copy link
Collaborator

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Pandapip1 Pandapip1 merged commit b12948c into nix-community:master Feb 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants