wslConf: convert to freeform type #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe make it proper RFC42 then? |
nzbr
force-pushed
the
wsl-conf-extra-options
branch
from
2722456
to
cbf4d80
Compare
|
Should've read that earlier 😅 |
|
Maybe |
|
Wouldn't that be redundant? All the options currently in wsl.wslConf are 1:1 representations of the config file entries anyway, just with checks attached. I would keep the checks in place and just convert the whole thing to a freeform type |
|
I guess we could just keep |
nzbr
force-pushed
the
wsl-conf-extra-options
branch
from
cbf4d80
to
1c04890
Compare
nzbr
changed the title
nzbr
force-pushed
the
wsl-conf-extra-options
branch
from
1c04890
to
447a110
Compare
nzbr
force-pushed
the
wsl-conf-extra-options
branch
from
447a110
to
98e2afd
Compare
|
Done, seems to work just fine from my quick test |
SuperSandro2000
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #559
Pretty much what it says on the tin