Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop flake-utils #613

Merged
merged 1 commit into from
Jan 5, 2025
Merged

refactor: drop flake-utils #613

merged 1 commit into from
Jan 5, 2025

Conversation

isabelroses
Copy link
Contributor

flake-utils' main utility is making flakes easier to make. but more modernly they don't provide much utility above of overrideable systems, which is not being utlised here since eachSystem is being used. So instead lets remove the input and vendor our own forAllSystems function to recreate what we previously used flake-utils for.

flake-utils' main utility is making flakes easier to make. but more
modernly they don't provide much utility above of overrideable systems,
which is not being utlised here since `eachSystem` is being used. So
instead lets remove the input and vendor our own `forAllSystems`
function to recreate what we previously used flake-utils for.
@nzbr
Copy link
Member

nzbr commented Jan 5, 2025

Agreed, pulling in less dependencies is usually a good thing. I'm unsure if it wouldn't be better to keep the forAllSystems on the flake level like it was with flake-utils instead of running it once per output. Your version is definitely more readable, so I'd say we keep it like that unless it causes problems

@nzbr nzbr merged commit 63c3b4e into nix-community:main Jan 5, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants