treewide: use graphical-session.target for GUI services #5785
+57
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking this as a draft, as there are many more occurrences of |
Scrumplex
force-pushed
the
treewide/graphical-session-shenanigans
branch
from
4be05b0 to
a0c04bd
Compare
Scrumplex
force-pushed
the
treewide/graphical-session-shenanigans
branch
from
a0c04bd to
1215a00
Compare
Scrumplex
force-pushed
the
treewide/graphical-session-shenanigans
branch
2 times, most recently
from
615f913 to
00433e4
Compare
|
I have significantly expanded the scope of this PR to actually do a treewide change.
In case you think that a module was moved to the later target unreasonably, feel free to start a review! |
Scrumplex
force-pushed
the
treewide/graphical-session-shenanigans
branch
from
00433e4 to
6a9f87b
Compare
CnTeng
approved these changes
Dec 24, 2024
Redhawk18
approved these changes
Dec 24, 2024
|
@Scrumplex Are you still willing to work on this, I know it's been a while. |
As per systemd.special(7)[0] graphical-session-pre.target is strictly for units that set up things for a graphical session. Most notably, these are usually started *before* the compositor/session is actually ready. While Home Manager's current implementation of graphical-session.target allows these units to work regardless of what systemd.special(7) specifies, other setups like ones with uwsm[1] do not allow these units to start properly. [0]: https://www.freedesktop.org/software/systemd/man/latest/systemd.special.html#graphical-session-pre.target [1]: https://github.com/Vladimir-csp/uwsm Signed-off-by: Sefa Eyeoglu <[email protected]>
Scrumplex
force-pushed
the
treewide/graphical-session-shenanigans
branch
from
6a9f87b to
823cc54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per systemd.special(7)[0] graphical-session-pre.target is strictly
for units that set up things for a graphical session. Most notably,
these are usually started before the compositor/session is actually
ready.
While Home Manager's current implementation of graphical-session.target
allows these units to work regardless of what systemd.special(7)
specifies, other setups like ones with uwsm[1] do not allow these units
to start properly.
Signed-off-by: Sefa Eyeoglu [email protected]
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allornix develop --ignore-environment .#allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC