Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libnixf: split sema-unused-def into let, arg and formal #565

Merged
merged 8 commits into from
Aug 2, 2024
Merged

libnixf: split sema-unused-def into let, arg and formal #565

merged 8 commits into from
Aug 2, 2024

Conversation

Aleksanaa
Copy link
Collaborator

@Aleksanaa Aleksanaa commented Aug 1, 2024 •
edited by inclyc
Loading

Related NixOS/nixpkgs#331085

Fixes: #558

@Aleksanaa Aleksanaa requested a review from inclyc as a code owner August 1, 2024 15:36
inclyc
inclyc requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@inclyc inclyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing on tests.

inclyc
inclyc reviewed Aug 1, 2024
View reviewed changes
libnixf/src/Basic/diagnostic.py Outdated Show resolved Hide resolved
libnixf/src/Sema/VariableLookup.cpp Outdated Show resolved Hide resolved
inclyc
inclyc reviewed Aug 2, 2024
View reviewed changes
libnixf/src/Sema/VariableLookup.cpp Outdated Show resolved Hide resolved
libnixf/src/Sema/VariableLookup.cpp Outdated Show resolved Hide resolved
inclyc
inclyc approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@inclyc inclyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

inclyc
inclyc approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@inclyc inclyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG again.

inclyc
inclyc requested changes Aug 2, 2024
View reviewed changes
libnixf/src/Basic/diagnostic.py Outdated Show resolved Hide resolved
libnixf/src/Sema/VariableLookup.cpp Outdated Show resolved Hide resolved
inclyc
inclyc approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@inclyc inclyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inclyc inclyc merged commit d687efa into nix-community:main Aug 2, 2024
19 checks passed
@inclyc inclyc added enhancement New feature or request libnixf:sema Semantic analysis in libnixf labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inclyc inclyc inclyc approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request libnixf:sema Semantic analysis in libnixf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvements on unused argument detection in { foo, bar }@args
2 participants
@Aleksanaa @inclyc