Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixd/Controller: handle UTF-16 code units for locations #580

Merged
merged 2 commits into from
Aug 11, 2024
Merged

nixd/Controller: handle UTF-16 code units for locations #580

merged 2 commits into from
Aug 11, 2024

Conversation

inclyc
Copy link
Member

@inclyc inclyc commented Aug 10, 2024

截屏2024-08-11 00 02 30

Handle LSP spec (UTF16) character length for locations.

inclyc
inclyc commented Aug 11, 2024
View reviewed changes
Copy link
Member Author

@inclyc inclyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing the file every time requesting the location may not be a good solution. I'd like to see a caching / preprocessing service for LSP locations.

@inclyc inclyc added the enhancement New feature or request label Aug 11, 2024
@inclyc inclyc marked this pull request as ready for review August 11, 2024 12:37
@inclyc inclyc linked an issue Aug 11, 2024 that may be closed by this pull request
unicode #575
Closed
@inclyc inclyc merged commit 9b9ba70 into main Aug 11, 2024
38 checks passed
@inclyc inclyc deleted the rework-locations branch August 11, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unicode
1 participant
@inclyc