Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libnixf: remove sema-escaping-with because it is too pedantic #582

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

inclyc
Copy link
Member

@inclyc inclyc commented Aug 11, 2024

This diagnostic highlighted too much.
In some cases, people may use "let" expression to override something inside with pkgs;

If "escaping-with" is diagnosed, there is no good fix to workaround, without completely disable that diagnostic in configuration.

CC @Aleksanaa who previously worked on this.

This diagnostic highlighted too much.
In some cases, people may use "let" expression to override something inside `with pkgs;`

If "escaping-with" is diagnosed, there is no good fix to workaround,
without completely disable that diagnostic in configuration.
@inclyc inclyc linked an issue Aug 11, 2024 that may be closed by this pull request
@inclyc inclyc added the bug Something isn't working label Aug 11, 2024
@inclyc inclyc merged commit c9d8970 into main Aug 11, 2024
38 checks passed
@inclyc inclyc deleted the libnixf/remove-sema-escaping-with branch August 11, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disable sema-escaping-with
1 participant