[wip] fix compilation with nix 2.24 #613
Open
+110
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
force-pushed
the
nix-2.24
branch
2 times, most recently
from
de9bd4e
to
cfb263f
Compare
13 tasks
Mic92
force-pushed
the
nix-2.24
branch
4 times, most recently
from
09ae492
to
a492669
Compare
Mic92
commented
Nov 7, 2024
nixd/lib/Eval/AttrSetProvider.cpp
Outdated
| State.forceValue(*It->value, It->pos); | ||
|
|
||
| // In nixpkgs some examples are nested in "literalExpression" | ||
| if (nixt::checkField(State, *It->value, "_type", "literalExpression")) { | ||
| R.Example = nixt::getFieldString(State, *It->value, "text"); | ||
| } else { | ||
| std::ostringstream OS; | ||
| It->value->print(State.symbols, OS); | ||
| // TODO: replace this with something that can traverse the symbol table | ||
| //It->value->print(State.symbols, OS); |
There was a problem hiding this comment.
@inclyc unsure what to do here. We need symbols to be looked up here in the table. I suppose they should come from IT somehow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.