flake-modules: minor tweaks from #1629 #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattSturgeon
force-pushed
the
fmt_cherry_pick
branch
2 times, most recently
from
2b50942
to
922cd7b
Compare
Added to ignore a treewide reformatting commit when using `git blame`. See [GitHub's Documentation][1] and the [`git blame` manual][2]. [1]: https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view [2]: https://www.git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt
treefmt isn't actually using flake-root to find the flake's root; it does it itself. All we were doing was passing flake-root's default `projectRootFile` to treefmt, which is `"flake.nix"`;
Remove explicit `formatter = config.treefmt.build.wrapper`, because treefmt's `flakeFormatter` option (default `true`) handles that for us.
MattSturgeon
force-pushed
the
fmt_cherry_pick
branch
from
922cd7b
to
a54ee8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the less controversial commits from #1629, as well as a couple new commits: