Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: cleanup #3045

Merged
merged 2 commits into from
Mar 4, 2025
Merged

tests: cleanup #3045

merged 2 commits into from
Mar 4, 2025

Conversation

GaetanLepage
Copy link
Member

  • tests: re-enable tests that work
  • tests/none-ls: remove beautysh test (removed upstream)

@GaetanLepage GaetanLepage changed the title tests/cleanup tests: cleanup Mar 4, 2025
MattSturgeon
MattSturgeon approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@MattSturgeon MattSturgeon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

CI still passes and the diff looks good.

NOTE: if there's any conflicts with #2991, it may get partially reverted when the CI does its cherry-pick, so we may have to manually un-revert. Or manually rebase #2991 before the CI has chance to run.

@GaetanLepage
Copy link
Member Author

@mergify queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 4, 2025 •
edited
Loading

queue

🛑 The pull request has been merged manually

The pull request has been merged manually at 03065fd

@GaetanLepage GaetanLepage merged commit 03065fd into nix-community:main Mar 4, 2025
3 checks passed
@GaetanLepage GaetanLepage deleted the cleanup branch March 4, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattSturgeon MattSturgeon MattSturgeon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GaetanLepage @MattSturgeon