Add group settings for Attack, Reinforce and Dynamic Reinforcement #441
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -108,6 +108,70 @@ _curCat = LSTRING(Settings_GeneralCat); | |||||
| 1 | ||||||
| ] call CBA_fnc_addSetting; | ||||||
|
|
||||||
| addMissionEventHandler ["GroupCreated", { | ||||||
|
There was a problem hiding this comment. This should probably be in the EventHandlers pbo |
||||||
| params ["_group"]; | ||||||
| [ | ||||||
| { | ||||||
| if (count (units _this) > 0) then { | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| if (GVAR(autoAddDynamicReinforcement)) then {_this setVariable [QGVAR(enableGroupReinforce), true, true];}; | ||||||
|
There was a problem hiding this comment. i think we maybe should split this up into a more logical system. why should we, for example, wait when all 3 settings are disabled? There was a problem hiding this comment. It's a 3-second wait before executing ( |
||||||
| if !(GVAR(disableAttackOverride)) then {_this enableAttack false;}; | ||||||
| if (GVAR(disableFleeingOverride)) then {_this allowFleeing 0;}; | ||||||
| }; | ||||||
| }, | ||||||
| _group, | ||||||
| 3 | ||||||
| ] call CBA_fnc_waitAndExecute; | ||||||
| }]; | ||||||
|
|
||||||
| // auto disable enableAttack on groups | ||||||
| [ | ||||||
| QGVAR(disableAttackOverride), | ||||||
| "CHECKBOX", | ||||||
| [LSTRING(Settings_AttackOverride), LSTRING(Settings_AttackOverride_ToolTip)], | ||||||
| [COMPONENT_NAME, _curCat], | ||||||
| false, | ||||||
| false, { | ||||||
| params ["_value"]; | ||||||
| if (_value) exitWith {}; | ||||||
| if (!_value && time > 0) then { | ||||||
| {_x enableAttack false;} forEach (allGroups select {local (leader _x)}); | ||||||
| }; | ||||||
| } | ||||||
| ] call CBA_fnc_addSetting; | ||||||
|
|
||||||
| // auto disable allowFleeing on groups | ||||||
| [ | ||||||
| QGVAR(disableFleeingOverride), | ||||||
|
There was a problem hiding this comment. This and the next setting need a XEH initPost eventhandler instead. People spawn in units all the time, which will not get caught by this. |
||||||
| "CHECKBOX", | ||||||
| [LSTRING(Settings_FleeingOverride), LSTRING(Settings_FleeingOverride_ToolTip)], | ||||||
| [COMPONENT_NAME, _curCat], | ||||||
| false, | ||||||
| false, { | ||||||
| params ["_value"]; | ||||||
| if (_value) exitWith {}; | ||||||
| if (!_value && time > 0) then { | ||||||
| {_x allowFleeing 0;} forEach (allGroups select {local (leader _x)}); | ||||||
| }; | ||||||
| } | ||||||
| ] call CBA_fnc_addSetting; | ||||||
|
|
||||||
| // auto add dynamic reinforcement | ||||||
| [ | ||||||
| QGVAR(autoAddDynamicReinforcement), | ||||||
| "CHECKBOX", | ||||||
| [LSTRING(Settings_UniversalDynamicReinforcement), LSTRING(Settings_UniversalDynamicReinforcement_ToolTip)], | ||||||
| [COMPONENT_NAME, _curCat], | ||||||
| false, | ||||||
| false, { | ||||||
| params ["_value"]; | ||||||
| if (!_value) exitWith {}; | ||||||
| if (_value) then { | ||||||
| {_x setVariable [QGVAR(enableGroupReinforce), true, true];} forEach (allGroups select {local (leader _x)}); | ||||||
| }; | ||||||
| } | ||||||
| ] call CBA_fnc_addSetting; | ||||||
|
|
||||||
|
|
||||||
| /* | ||||||
| TEMPORARILY DISABLED FOR VERSION 2.5 RELEASE | ||||||
| WAITING BETTER OR OTHER SOLUTION | ||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can find, the former
personnellwas closer, should just drop the extra trailingl. Still, I'd go withpeopleinstead, since seeminglypersonnelis people working in a company: